Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(python) Incorrect docs translation of three letter acronyms in property names #872

Open
mrgrain opened this issue Feb 19, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation p1

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Feb 19, 2024

https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs/ServiceManagedEBSVolumeConfiguration.html

Is managed_eBSVolume
Should be managed_ebs_volume

        volume = ecs.ServiceManagedVolume(self, "EBSVolume",
            name="ebs1",
            managed_ebs_volume=ecs.ServiceManagedEBSVolumeConfiguration(
                size= Size.gibibytes(15),
                volume_type=ec2.EbsDeviceVolumeType.GP3,
                file_system_type=ecs.FileSystemType.XFS,
                tag_specifications=[ecs.EBSTagSpecification(
                    tags={
                        "purpose": "production"
                    },
                    propagate_tags=ecs.EbsPropagatedTagSource.SERVICE
                )]
            )
        )
@iliapolo
Copy link
Contributor

@mrgrain this is a bug with generated example code only, right?

@mrgrain
Copy link
Contributor Author

mrgrain commented Feb 22, 2024

I thought it's a bug with transliterating an example from TS to Python. But I might be wrong.

@iliapolo iliapolo added the documentation Improvements or additions to documentation label Feb 22, 2024
@iliapolo
Copy link
Contributor

Yeah it might be that, I just meant its not a runtime issue, but a doc issue 👍

@iliapolo iliapolo changed the title (python) Incorrect translation of three letter acronyms in property names (python) Incorrect docs translation of three letter acronyms in property names Feb 22, 2024
@mrgrain mrgrain added the p1 label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1
Projects
None yet
Development

No branches or pull requests

2 participants