Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle case of str to bool env variable in config #2966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle case of str to bool env variable in config #2966

wants to merge 2 commits into from
+10 −0

Conversation

jaidisido
Copy link
Contributor

@jaidisido jaidisido commented Sep 17, 2024 •
edited
Loading

Feature or Bugfix

  • Bugfix

Detail

Handling the special case where WR_ environment variables are read as str but are intended as bool. This is similar to how we currently handle null values.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Sep 17, 2024
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 47bf607
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 47bf607
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido marked this pull request as ready for review September 17, 2024 12:15
@jaidisido jaidisido linked an issue Sep 17, 2024 that may be closed by this pull request
Environment variable WR_CTAS_APPROACH never work #2965
Open
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 2c757db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 2c757db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking Awaiting requested review from kukushking

@LeonLuttenberger LeonLuttenberger Awaiting requested review from LeonLuttenberger

At least 2 approving reviews are required to merge this pull request.

Assignees

@jaidisido jaidisido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variable WR_CTAS_APPROACH never work
2 participants
@jaidisido @malachi-constant