Expose CLI flag to tell Smee (Boots) on which interface to bind #8760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added a cli flag option
--smee-bind-ip
, which tells smee service on which interface to bind it's services for serving pxe boot binaries (http, tftp etc..)Currently EKS-A uses the default smee behaviour, which binds it's services on the first available hosts public interface. This causes an issue with the admin host if it is using multiple interfaces, as the "first" interface in the list is not necessarily the the one that's intended to be used as EKS-A network.
Testing (if applicable):
Added a test case for TestTinkerbellStackInstallWithDifferentOptions in
pkg/providers/tinkerbell/stack/stack_test.go
which checks thedocker run
command for boots service.Additionally added validations in SetupAndValidateCreateCluster() which checks if the provided IP is valid and bound to any network interface on the host.
All unit tests pass.
Documentation added/planned (if applicable):
Updated
docs/content/en/docs/reference/eksctl/anywhere_create_cluster.md
with the new CLI optionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.