feat(s2n-quic-events): add search_completed boolean to mtu updated event #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a
search_completedboolean field to themtu_updatedevent, to indicate when MTU probing has completedCall-outs:
At the time the MTU is changed (after a probe is acked for example), we often don't know if that MTU value is going to be the final MTU, so the search_completed flag will be false. It some cases, the MTU may not change again, but we this PR will emit an additional
mtu_updatedevent in these cases to update thesearch_completedflag.Testing:
Added tests and integration tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.