Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup swf parsing #3194

Merged
merged 6 commits into from
Feb 28, 2021
Merged

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Feb 11, 2021

Refactor a few things in swf, no functional changes

Copy link

@seanpm2001 seanpm2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping to optimize this project. There is still a lot that needs to be fixed, but I don't know where to start, as I am not the best at Rust development. Shortening strings was a good step, and removing unneeded scripts was needed, however I don't know which ones caused the tests to fail. Code optimization is rare these days, and I appreciate when people take the time to do it. This definitely needs further review.
Also, don't be too hard on yourself. I wouldn't consider this to be a bad chore. I am hoping that you implied this to be a good chore, as it is.

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 11, 2021

Haha, yeah, definitely didn't mean this as a bad chore; I simply used that keyword to make it easy for others to see that this was a code-only change (in contrast to adding a feature or fixing a bug)

@Herschel
Copy link
Member

Thanks, sorry for the delay!

@Herschel Herschel merged commit 121ae43 into ruffle-rs:master Feb 28, 2021
@madsmtm madsmtm deleted the cleanup-swf-parsing branch March 2, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants