Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited redirect #1637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limited redirect #1637

wants to merge 1 commit into from

Conversation

raomin
Copy link

@raomin raomin commented Jul 13, 2023

When I connect to wifimanager from my windows, it generates many requests (eg wpad/wpad.dat, autodiscover, etc.).
All these requests end up being served by wifimanager twice: once for redirect and a second time as 404.
It's often so consuming for asyncweb that the esp32 ends up crashing and my pc disconnected.
It's often better from my mobile where I get less extra requests.

However, I believe we shouldn't redirect these extra requests in the first place. With this change, I see no more crashes nor disconnections.

@raomin
Copy link
Author

raomin commented Jul 13, 2023

Note: I took the list of redirection detection from here. I tested with windows, ios and android.

@tablatronix
Copy link
Collaborator

Yeah you are supposed to turn off all data when using captive portals but adding a filter is a good idea problem is keeping up with it there are no standards and they all randomly change

@tablatronix tablatronix added the enhancement Feature Request label Nov 4, 2023
@tablatronix
Copy link
Collaborator

Add custom or callout for captive checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants